Switch to c++14 #155
Merged
Switch to c++14 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
griwodz
approved these changes
Feb 17, 2021
| @@ -5,6 +5,9 @@ if(NOT CMAKE_SOURCE_DIR STREQUAL PROJECT_SOURCE_DIR) | |||
| include(GNUInstallDirs) | |||
| set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/${CMAKE_SYSTEM_NAME}-${CMAKE_SYSTEM_PROCESSOR}") | |||
| set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${PROJECT_BINARY_DIR}/${CMAKE_SYSTEM_NAME}-${CMAKE_SYSTEM_PROCESSOR}") | |||
|
|
|||
| set(CMAKE_CXX_STANDARD 14) | |||
There was a problem hiding this comment.
Is the CCTAG_CXX_STANDARD variable automatically visible in src/applications/CMakeLists.txt. It would be convenient if it could be reused here.
There was a problem hiding this comment.
bad comment, because this is in the standalone branch, withdrawing it
|
@fabiencastan can we merge? |
fabiencastan
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to c++14 standard.
That automatically requires raising the minimum version of the compilers (gcc >= 5, clang >= 3.4, msvc >= 2017) and the cuda sdk >= 9.0.