[cctag] fix (potential) access out of bound error in opencv #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when approved, I'd like to run the code formatting for this file alone before merging, because it's hard to read (but I didn't want to pollute the PR) |
griwodz
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a reported crash when running in debug with access out of bound raised by OpenCV,
In reality, there is no real access to the memory but just the declaration of a pointer that may point outside the memory. All the operations are then made in the safe bound.
The solution is to move the declaration inside the good range.
fix #179
Note: to reproduce this behavior on a non-windows machine the
_DEBUGpreprocessor must be defined because the assert raising the error is defined based on that definition in OpenCV