-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use TBB oneAPI #200
Use TBB oneAPI #200
Conversation
cmake 3.24 boost 1.70.0 eigen 3.4.0 opencv 4.5.3
@p12tic there still 1 issue that I have to commit and it is related to this #ifndef _GNU_SOURCE
#define _GNU_SOURCE
#endif or is it better to add the definition in cmake with |
@simogasp I didn't see any problems with boost + aliceVision on macOS. What exact symptoms are you seeing? |
I don't know if it depends on the version, but (on Silicon) I had a similar compiling error as boostorg/stacktrace#88 |
and they add this patch on vcpkg to the cctag port as well when they bumped the tbb version |
Interesting, I'm also on Apple arm64 and boost 1.76. It could be that the reason why I'm not seeing problems is that currently I'm compiling macports environment which likely has different libraries. |
Ah, I'm not actually compiling cctag component on macOS, sorry for the noise (facepalm). Anyway, defining _GNU_SOURCE in this case shouldn't cause any problems. |
@simogasp Appveyor build fails because of incorrect expected archive hash. |
yes it must be the cache, we should move to github actions like AV where we can keep control of vcpkg version, even though is less annoying here given the relatevelt fewer dependencies |
ah yes this breaks the appveyor CI as oneAPI is not yet in the version of vcpkg shipped with the appveyor image. |
22eb3bf
to
a548428
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR. Just asking for one small change.
f56d4b4
to
105e595
Compare
This PR is a rework of #178 to enable building with the new TBB oneAPI.
Contrary to the previous, this breaks the compatibility with previous versions of TBB, as the cmake now uses CONFIG.
Major changes:
When merged we can make a patch release and submit a PR to vcpgk to bump the version as well. These changes are already taken into account in vcpkg by patches that do more or less the same thing.