[Applications] Show detected markers in video and live mode #33
Conversation
'l' and 'd' for debug mode (ie it wait for a key to be pressed at each frame)
simogasp
changed the title
| @@ -116,7 +116,7 @@ void CmdLine::usage( const char* const argv0 ) | |||
| " [--use-cuda]\n" | |||
| " [--parallel <n>]\n" | |||
| "\n" | |||
| " <imgpath> - path to an image (JPG, PNG) or video\n" | |||
| " <imgpath> - path to an image (JPG, PNG) or video(avi, mov) or camera index for live capture (0, 1...)\n" | |||
There was a problem hiding this comment.
missing space video(avi, mov)
| cv::cvtColor(imgGray, frame, cv::COLOR_GRAY2BGRA); | ||
|
|
||
| drawMarkers(markers, frame); | ||
| cv::imshow(windowName, frame); |
There was a problem hiding this comment.
Using a UI should be an option.
| */ | ||
| bool isInteger(std::string s) | ||
| { | ||
| std::regex e("^-?\\d+"); |
There was a problem hiding this comment.
this sadly crashes at runtime with gcc4.8 (ubuntu 14.04.05) as regex apparently are not fully supported in that version. I'll find a workaround...
There was a problem hiding this comment.
We're not going to have 10 cameras anytime soon so replace it with s.size()==1 && std::isdigit(s[0]).
There was a problem hiding this comment.
yeah maybe your right, it was a bit overkilling it... ;-)
| */ | ||
| void drawMarkers(const boost::ptr_list<CCTag> &markers, cv::Mat &image) | ||
| { | ||
| BOOST_FOREACH(const cctag::CCTag & marker, markers) |
There was a problem hiding this comment.
In C++11 there's no reason whatsoever to use BOOST_FOREACH. Use for (const auto& marker : markers) { ... }
| #endif // WITH_CUDA | ||
|
|
||
| bfs::path myPath( cmdline._filename ); | ||
| bfs::path myPath(bfs::absolute(cmdline._filename)); |
There was a problem hiding this comment.
bfs ?! Be consistent, either use bfs or boost::filesystem everywhere, but don't mix them.
| frames.push_back( imgGray ); | ||
| } | ||
| std::cerr << "Done. Now processing." << std::endl; | ||
| boost::timer t; |
There was a problem hiding this comment.
Shouldn't the timer be inside the for-loop if the meaning is to measure per-frame time? You should also instantiate it just before calling detection. Could also upgrade to use the new timer implementation: http://www.boost.org/doc/libs/1_49_0/libs/timer/doc/cpu_timers.html
In any case, it seems to be unused, so just remove it.
There was a problem hiding this comment.
yes i just forgot to remove it from the previous version, there is already a timer inside detection
Modified the
detection.cppexample so that you can see the detected markers on a UI (similar to appCutie) when using a video (and I added the support for webcams)