NearbyPoint bug fix and minor fixes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
commented
Nov 26, 2016
| @@ -863,9 +863,9 @@ void cctagDetection( | |||
| /* identification in CUDA requires a host-side nearby point struct | |||
| * in pinned memory for safe, non-blocking memcpy. | |||
| */ | |||
| if( markers.size() > 60 ) { | |||
There was a problem hiding this comment.
@lcalvet: is that ok for you?
|
The scale should not be exposed as it could be interpret as the scale of a point of interest, typically like in SIFT, SURF, etc. and could therefore be used for sorting purpose, etc. which doesn't make any sense. |
|
|
fcastan
force-pushed
the
dev_nearbyPoint_fixes
branch
2 times, most recently
from
629688e to
1b4ce2f
Compare
|
I removed the commit which expose the scale & quality. |
instead of checking width/height separately
fcastan
force-pushed
the
dev_nearbyPoint_fixes
branch
from
1b4ce2f to
ebc8a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.