-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WebView from react-native-webview as it has been deprecated from … #289
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this before WebView deprecation in RN 0.59+
Hard for me to review changes in index.ios.js by just looking at diff, due to a lot of code re-ordering. I'll test later and comment. I assume you have tested this PR in your own app?
Yes, I'm currently using this PR in my own app. |
One more thing: I think we will also need to add |
Yup. @chansuke merge please? |
@chansuke? Is no one maintaining this again? I confirm this PR works perfectly in my app WonderSwipe, and is needed for RN 0.59.5. Please merge. |
@fungilation Could you merge it? |
Nope. No write access. |
this still needs to be fixed |
Use WebView from react-native-webview as it has been deprecated from react-native and will be removed in future release.
See https://facebook.github.io/react-native/docs/webview for more info.