Warn on implicit no remote store #893
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more clear when we're recompiling everything ourselves
ktf
reviewed
Dec 13, 2024
| @@ -451,6 +452,11 @@ def doBuild(args, parser): | |||
| 'Maybe you need to "cd" to the right directory or ' | |||
| 'you forgot to run "aliBuild init"?' % args.configDir) | |||
|
|
|||
| if (not args.no_remote_store and | |||
There was a problem hiding this comment.
The change itself is fine for me. What happens on platforms where we prefer the system tools, like on macOS?
Could you add a test which exercises this part of the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more clear when we're recompiling everything ourselves
I'm adding it here instead of in
alibuild_helpers/args.pybecause the logger is not initialized yet during the arg parsingI'm honestly not very convinced about how this change turned out, if there's any suggestion on how to improve it, please let me know