Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DC-3635] Remove portion of query checking primary consent #1834

Merged
merged 2 commits into from
Dec 21, 2023
Merged

[DC-3635] Remove portion of query checking primary consent #1834

merged 2 commits into from
Dec 21, 2023

Conversation

dev-michael-schmidt
Copy link
Contributor

@dev-michael-schmidt dev-michael-schmidt commented Dec 18, 2023 •
edited
Loading

This PR remove the portion of checks where wear_consent participants must have primary consent.

Ticket
Investigation

@dev-michael-schmidt dev-michael-schmidt marked this pull request as ready for review December 19, 2023 14:35
ksdkalluri
ksdkalluri requested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ksdkalluri ksdkalluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelSchmidt82 there is also a similar check in check_controlled_tier_part2.py that checks for primary consent for wear participants that needs to be removed as well as per the scope of the ticket.

@dev-michael-schmidt
Copy link
Contributor Author

@MichaelSchmidt82 there is also a similar check in check_controlled_tier_part2.py that checks for primary consent for wear participants that needs to be removed as well as per the scope of the ticket.

Good catch!

ksdkalluri
ksdkalluri approved these changes Dec 21, 2023
View reviewed changes
data_steward/analytics/cdr_ops/rt_cdr_qc/cdr_deid_qa_report10_extra.py
@@ -866,26 +866,6 @@ def my_sql(table_name, column_name):
SELECT person_id
FROM `{{project_id}}.{{rt_cdr_deid}}.person` o
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelSchmidt82 you would also need to update the comment for this check to remove primary_consent related info.

@dev-michael-schmidt dev-michael-schmidt merged commit cf48b80 into develop Dec 21, 2023
1 check passed
@dev-michael-schmidt dev-michael-schmidt deleted the ms/dc-3635 branch December 21, 2023 19:37
dev-michael-schmidt pushed a commit that referenced this pull request Jan 22, 2024
[DC-3635] Remove portion of query checking primary consent (#1834)
4baf50d 
* [DC-3635] Remove portion of query checking primary consent

* [DC-3635] Remove fitbit check in CT
ratuagga pushed a commit that referenced this pull request Feb 2, 2024
@ratuagga
[DC-3635] Remove portion of query checking primary consent (#1834)
ed403e4 
* [DC-3635] Remove portion of query checking primary consent

* [DC-3635] Remove fitbit check in CT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksdkalluri ksdkalluri ksdkalluri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dev-michael-schmidt @ksdkalluri