[DC-3673] Remove notebook check regarding cause_source_concept_id for aou_death #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendagutman
approved these changes
Jan 12, 2024
dev-michael-schmidt
pushed a commit
that referenced
this pull request
Jan 22, 2024
… aou_death (#1845) * [DC-3673] Delete query * [DC-3673] change "df1" to "result" * [DC-3673] change "df" to "summary" * [DC-3673] Minor formatting
ratuagga
pushed a commit
that referenced
this pull request
Feb 2, 2024
… aou_death (#1845) * [DC-3673] Delete query * [DC-3673] change "df1" to "result" * [DC-3673] change "df" to "summary" * [DC-3673] Minor formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DC-1661 removed the death(currently aou_death) table from the affected tables of drop_zero_concept_ids. However, the notebook check regarding this issue was not removed.
This PR removes the check
See DC-3673, the ticket
See DC-1661, ticket excluding death table in RT.
Note:
variable
df1is renamed toresultfor better clarity and contextvariable
dfis renamed tosummaryfor better clarity and contextThese are mostly in two separate commits should the reviewer want to revert the names
dfand/ordf1for convenience.