python3 fix

[askovpen]

in python3.4:

NameError: name 'basestring' is not defined

[dvander]

This is not quite right, since on Python 2.7:

>>> isinstance('', str)
True
>>> isinstance(u'', str)
False

Probably the right thing to do is check isinstance(blah, basestring) on Python 2 (I usually check if str == bytes for that), and isinstance(blah, str) on Python 3.

[powerlord]

@dvander So, are you saying IsString should be rolled back to its old version?

[dvander]

Not quite, the old version doesn't use isinstance.

[WildCard65]

@dvander Would doing a check of sys.version_info work?