-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove 7685 request variants #1515
Conversation
35b78d5
to
9de3533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can also rm these:
alloy/crates/eips/src/eip7002.rs
Lines 30 to 38 in b4a435d
pub struct WithdrawalRequest { | |
/// Address of the source of the exit. | |
pub source_address: Address, | |
/// Validator public key. | |
pub validator_pubkey: FixedBytes<48>, | |
/// Amount of withdrawn ether in gwei. | |
#[cfg_attr(feature = "serde", serde(with = "alloy_serde::quantity"))] | |
pub amount: u64, | |
} |
alloy/crates/eips/src/eip7251.rs
Lines 25 to 32 in b4a435d
pub struct ConsolidationRequest { | |
/// Source address | |
pub source_address: Address, | |
/// Source public key | |
pub source_pubkey: FixedBytes<48>, | |
/// Target public key | |
pub target_pubkey: FixedBytes<48>, | |
} |
alloy/crates/eips/src/eip6110.rs
Lines 20 to 33 in b4a435d
pub struct DepositRequest { | |
/// Validator public key | |
pub pubkey: FixedBytes<48>, | |
/// Withdrawal credentials | |
pub withdrawal_credentials: B256, | |
/// Amount of ether deposited in gwei | |
#[cfg_attr(feature = "serde", serde(with = "alloy_serde::quantity"))] | |
pub amount: u64, | |
/// Deposit signature | |
pub signature: FixedBytes<96>, | |
/// Deposit index | |
#[cfg_attr(feature = "serde", serde(with = "alloy_serde::quantity"))] | |
pub index: u64, | |
} |
we just need the addresses + bytecode from these now, not even the request type constants, since this is determined by the position of the request in the Requests
struct anyway
ded0bf4
to
4a99c06
Compare
4a99c06
to
c16027c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
* chore: remove 7685 request variants * keep addresses and code * fix docs
these got removed and replaced with a general purpose request blob