feat: derive serde for ExecutionPayloadSidecar
#1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
requested review from
DaniPopes,
gakonst,
mattsse and
emhane
as code owners
onbjerg
force-pushed
the
onbjerg/sidecar-serde
branch
from
cb5530e to
fb7964c
Compare
mattsse
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have an interceptor in Reth that stores engine API messages, including extra fields, which are now present in the sidecar. This interceptor stores them on disk by serializing them with serde.
Solution
Derive
Serialize/Deserializefor the sidecar.PR Checklist