Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend FeeHistory type with eip-4844 fields #188

Merged
merged 2 commits into from
Feb 6, 2024
Merged

feat: extend FeeHistory type with eip-4844 fields #188

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c31df8
feat: extend FeeHistory type with eip-4844 fields
allnil Feb 6, 2024
fd0e27c
feat: add skip_serializing for the new fields
allnil Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/rpc-types/src/eth/fee.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ pub struct FeeHistory {
///
/// The `Option` is only for compatability with Erigon and Geth.
pub gas_used_ratio: Vec<f64>,
/// An array of block base fees per blob gas. This includes the next block after the newest
/// of the returned range, because this value can be derived from the newest block. Zeroes
/// are returned for pre-EIP-4844 blocks.
pub base_fee_per_blob_gas: Vec<U256>,
/// An array of block blob gas used ratios. These are calculated as the ratio of gasUsed and
/// gasLimit.
pub blob_gas_used_ratio: Vec<f64>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need to be option for now, because only supported after cancun
and skip if none

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be enough: #[serde(default, skip_serializing_if = "Vec::is_empty")]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need to be option for now, because only supported after cancun
and skip if none

The spec says just to fill with 0s for pre-cancun blocks, would this not be ok even with cancun not activated?

Copy link
Member

@DaniPopes DaniPopes Feb 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's if the network and RPC provider implements the EIP/Cancun

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right let's do

#[serde(default, skip_serializing_if = "Vec::is_empty")]

then @allnil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's both for base_fee_per_blob_gas and blob_gas_used_ratio or only for blob_gas_used_ratio?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both!

/// Lowest number block of the returned range.
pub oldest_block: U256,
/// An (optional) array of effective priority fee per gas data points from a single
Expand Down
Loading