Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAT-838 | Feature | Refactor business hour component adding rules #3

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

WAT-838 | Feature | Refactor business hour component adding rules #3

wants to merge 36 commits into from

Conversation

juanblariza-aloware
Copy link

@juanblariza-aloware juanblariza-aloware commented Sep 19, 2024 •
edited
Loading

🎫 Jira WAT-838

Counterpart Classic

Go to talk PR

📝 Changes

Change 1:

  • “Opens” and “Closes” are placeholders and are disabled to prevent the possibility of making a selection.
  • When you select the opening time for the first time, the closing time is automatically set 9 hours later.
  • When you select the closing time for the first time, the opening time is automatically set 9 hours earlier.
  • After the initial selection, you can freely choose the time for each selector.
  • If you need to set additional hours for the same date, the new opening time will start immediately after the closing time of the previous selector.

nestor-aloware
nestor-aloware reviewed Sep 19, 2024
View reviewed changes
Copy link

@nestor-aloware nestor-aloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments.

jefferson-aloware
jefferson-aloware suggested changes Sep 25, 2024
View reviewed changes
src/components/BusinessHoursSelect.vue Outdated
Comment on lines 58 to 67
props: {
isDisabled: {
type: Boolean,
default: false
},
is24hrsVisible: {
type: Boolean,
default: true
},
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move props to before data.

@tito-aloware tito-aloware changed the title Feature | Refactor business hour component adding rules WAT-838 | Feature | Refactor business hour component adding rules Sep 26, 2024
@tito-aloware
Copy link

Holding this merge until the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tito-aloware tito-aloware tito-aloware approved these changes

@jefferson-aloware jefferson-aloware jefferson-aloware approved these changes

@nestor-aloware nestor-aloware nestor-aloware approved these changes

@esteban-aloware esteban-aloware Awaiting requested review from esteban-aloware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@juanblariza-aloware @tito-aloware @nestor-aloware @jefferson-aloware @jcwirko