Return GraphQL response as GdsApi::Response
#1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
graphql-response
branch
from
bb3eed7
to
2511dec
Compare
This is instead of `Hash`. In Government Frontend, we need some other information from the request response (e.g. the cache control headers) which are not included when the response is converted to a hash. This is not a breaking change as the new object type accepts the same methods as the hash.
brucebolt
force-pushed
the
graphql-response
branch
from
2511dec
to
96ac0d7
Compare
mike3985
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is instead of
Hash.In Government Frontend, we need some other information from the request response (e.g. the cache control headers) which are not included when the response is converted to a hash.
This is not a breaking change as the new object type accepts the same methods as the hash.
Trello card