-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAU: Test-driven development #948
Conversation
e32e1fe
to
12652f4
Compare
I very much support adding TDD to The GDS Way! When I learned about TDD it was with a peer group who benefitted from a lot of time and support from our managers, which included regular, safe opportunities to practise our TDD skills with expert advice. I wonder if guidance is needed for those who are new to TDD and/or haven't had any training or coaching in it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks great,
We might consider adding some links to some more pratical / worked examples?
I feel like folks can struggle translating the theory into that early practice of "simple test" -> "oh i didn't import from my lib file", "oh i didn't write a class", "oh i didn't initalise the class with the required parameter", "oh there's no method called sum
" to get to that first green?
This page makes sense as a set of principles, but wonder if we can endorse a good worked example at the bottom that would help folks see the detail and build that muscle memory?
Can very much be added later.
Also a few nitpicks on Markdown formatting.
ab577a2
to
838afad
Compare
I completely agree - I've added some sections about "Getting started" and "Getting better" but I had a similar experience - pairing/mobbing and TDDing every day, which turbocharged my learning. I'd like us to do more training / support for people to get the same experience I did (which I'm also happy to do). |
Agree, I've linked two very good books (GOOS and By Example) but also Jason Gorman's page which has (a) his TDD book with many worked examples and (b) his 101 TDD Tips which is full of bitesize ... tips to improve your TDD. |
838afad
to
851a451
Compare
I support this approach from a quality engineering and testing perspective. The content looks really good. To achieve good quality tests that drive development, it's crucial to create a testing mindset and culture. Without that TDD may fail to produce intended outcomes. Completely agree with principles and the value TDD brings, but it is important that teams don't misunderstand it as one-stop solution for all testing needs. Hence I think it’s worth also define what TDD is not, to clarify its boundaries or distinguish it from other types of testing in the software development lifecycle. A few suggestions:
|
Thanks @mboban2024! I will fold your suggestions into the content |
851a451
to
991dc6e
Compare
991dc6e
to
b0bce2b
Compare
Content explaining what TDD is and why we advocate for it