Skip to content

Commit

Permalink
Apply suggestions from review with accessibility specialist
Browse files Browse the repository at this point in the history
  • Loading branch information
calvin-lau-sig7 authored Nov 22, 2024
1 parent 8448a39 commit 9f3be66
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/components/back-link/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Make sure the link takes users to the previous page they were on, in the state t

{% call wcagNote({id: "wcag-interact-back-links"}) %}

<p>Make sure no other interactive elements are too close to the Back link component. This is to make sure users can easily interact with the Back link component. This relates to <a href="https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html">WCAG 2.2 success criterion 2.5.8 Target size (minimum)</a>.</p>
<p>Make sure no other interactive elements are too close to the Back link component. This is to make sure users can easily interact with it. This relates to <a href="https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html">WCAG 2.2 success criterion 2.5.8 Target size (minimum)</a>.</p>
{% endcall %}

Where possible, ensure the back link works even when JavaScript is not available. If this is not possible, you should hide the back link when JavaScript is not available.
Expand Down
2 changes: 1 addition & 1 deletion src/components/breadcrumbs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ The breadcrumbs should start with your 'home' page and end with the parent secti

{% call wcagNote({id: "wcag-interact-breadcrumbs"}) %}

<p>Make sure no other interactive elements are too close to the Breadcrumbs component. This is to make sure users can easily interact with the Breadcrumbs component. This relates to <a href="https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html">WCAG 2.2 success criterion 2.5.8 Target size (minimum)</a>.</p>
<p>Make sure no other interactive elements are too close to the Breadcrumbs component. This is to make sure users can easily interact with it. This relates to <a href="https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html">WCAG 2.2 success criterion 2.5.8 Target size (minimum)</a>.</p>
{% endcall %}

There are 2 ways to use the breadcrumbs component. You can use HTML or, if you are using [Nunjucks](https://mozilla.github.io/nunjucks/) or the [GOV.UK Prototype Kit](https://prototype-kit.service.gov.uk), you can use the Nunjucks macro.
Expand Down
4 changes: 2 additions & 2 deletions src/components/button/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Align the primary action button to the left edge of your form.

{% call wcagNote({id: "wcag-interact-button"}) %}

<p>Do not decrease the height or target area of the Button component. This is to make sure users can easily interact with the Button component. This is to comply with <a href="https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html">WCAG 2.2 success criterion 2.5.8 Target size (minimum)</a>.</p>
<p>Do not decrease the height or target area of the Button component. This is to make sure users can easily interact with it. This is to comply with <a href="https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html">WCAG 2.2 success criterion 2.5.8 Target size (minimum)</a>.</p>
{% endcall %}

There are 2 ways to use the Button component. You can use HTML or, if you are using [Nunjucks](https://mozilla.github.io/nunjucks/) or the [GOV.UK Prototype Kit](https://prototype-kit.service.gov.uk), you can use the Nunjucks macro.
Expand Down Expand Up @@ -98,7 +98,7 @@ Do not only rely on the red colour of a warning button to communicate the seriou

Use the `govuk-button--inverse` modifier class to show white buttons on dark backgrounds – for example, in headers, custom components, and patterns with darker backgrounds.

Make sure all users can see the button – the white button and background colour must have a contrast ratio of at least 4.5:1 with white to meet [WCAG 2.2 success criterion 1.4.3 Contrast (minimum), level AA](https://www.w3.org/WAI/WCAG22/Understanding/contrast-minimum.html).
Make sure all users can see the button – the white button and background colour must have a contrast ratio of at least 4.5:1 to meet [WCAG 2.2 success criterion 1.4.3 Contrast (minimum), level AA](https://www.w3.org/WAI/WCAG22/Understanding/contrast-minimum.html).

{{ example({ group: "components", item: "button", example: "inverse", html: true, nunjucks: true, open: false }) }}

Expand Down
2 changes: 1 addition & 1 deletion src/get-started/focus-states/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ description: Some people use keyboards or other devices to navigate through a pa

Some people use keyboards or other devices to navigate through a page by jumping from one interactive element to the next. Focus states let users know which element they’re currently on and is ready to be interacted with.

Focus states in the GOV.UK Design System use a combination of yellow and black to make sure they meet [Web Content Accessibility Guidelines (WCAG) 2.2 success criterion 1.4.11 Non-text contrast, level AA](https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast.html) on any background colour used on GOV.UK.
Focus states in the GOV.UK Design System use a combination of yellow and black, along with a thick bottom border, to make sure they meet [Web Content Accessibility Guidelines (WCAG) 2.2 success criterion 1.4.11 Non-text contrast, level AA](https://www.w3.org/WAI/WCAG22/Understanding/non-text-contrast.html) on any background colour used on GOV.UK.

The yellow has a high contrast with dark backgrounds and the thick black border has a high contrast against light backgrounds.

Expand Down
2 changes: 1 addition & 1 deletion src/patterns/create-accounts/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Help users create an account for your service.
anchor: "wcag-reuse-account-information"
},
{
text: "make sure that cognitives tests, such as CAPTCHA, are not needed for users to create an account",
text: "make sure that cognitives tests, such as CAPTCHAs, are not needed for users to create an account",
anchor: "wcag-avoid-cognitive-test"
}
]
Expand Down

0 comments on commit 9f3be66

Please sign in to comment.