-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the core metalsmith postcss plugin #2258
Conversation
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site settings. |
354dd8f
to
7a76e7a
Compare
I wonder if this will unblock #1663 🤔 |
Ooh, interesting. Seems like it probably would. Edit: Yeah, I did a quick swap for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense, but this also bumps metalsmith to v2.5.0 which isn't currently mentioned in the PR or commit message.
Suggest either splitting in to a separate commit or updating the commit message to cover all the changes.
7a76e7a
to
3cdbd4d
Compare
Done! metalsmith bump here: #2259 |
Thanks for that! I think the changes to the |
Metalsmith is being updated fairly regularly now, and have an [official PostCSS plugin](https://github.com/metalsmith/postcss). We've been blocked on bumping some dependencies because of this (#2016). I've run `npm build` and there is one small prefixing change in the resulting CSS, but otherwise it's exactly the same.
3cdbd4d
to
ee324be
Compare
Metalsmith is being updated fairly regularly now, and have a core PostCSS plugin.
We've been blocked on bumping some dependencies prior to this (#2016), but are now able to fully bump
postcss
.I've run
npm build
and there is one small prefixing change in the resulting CSS, but otherwise it's exactly the same.In the generated IE8 CSS we go from:
.govuk-template{background-color:#f3f2f1;-webkit-text-size-adjust:100%;-ms-text-size-adjust:100%;text-size-adjust:100%;overflow-y:scroll}
to:
.govuk-template{background-color:#f3f2f1;-webkit-text-size-adjust:100%;-moz-text-size-adjust:100%;-ms-text-size-adjust:100%;text-size-adjust:100%;overflow-y:scroll}
and in the standard generated CSS we go from:
.govuk-template{background-color:#f3f2f1;-webkit-text-size-adjust:100%;-ms-text-size-adjust:100%;text-size-adjust:100%
to:
.govuk-template{background-color:#f3f2f1;-webkit-text-size-adjust:100%;-moz-text-size-adjust:100%;-ms-text-size-adjust:100%;text-size-adjust:100%
PostCSS major changelogs
8.0.0
7.0.0