Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: EoinShaughnessy <[email protected]>
  • Loading branch information
36degrees and EoinShaughnessy authored Dec 2, 2021
1 parent 878e9ba commit d0ae7e4
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ This change was introduced in [pull request #2323: Avoid invalid nesting of `<sp

We've updated the HTML for the header. This update only affects you if your header includes navigation.

If you are not using Nunjucks macros then you should:
If you're not using Nunjucks macros, then you should move:

- move the `<button>` inside the `<nav>`, immediately before the `<ul>`
- move the `aria-label` from the `<ul>` to the `<nav>`
- the `<button>` inside the `<nav>`, immediately before the `<ul>`
- the `aria-label` from the `<ul>` to the `<nav>`

Check your changes against [the example in the Design System](https://design-system.service.gov.uk/components/header/#header-with-service-name-and-navigation).
Check your changes against the [header example in the Design System](https://design-system.service.gov.uk/components/header/#header-with-service-name-and-navigation).

This change was introduced in [pull request #2427: Improvements to the screen reader experience for the menu in the header](https://github.com/alphagov/govuk-frontend/pull/2427).
This change was introduced in [pull request #2427: Improve the screen reader experience for the header menu](https://github.com/alphagov/govuk-frontend/pull/2427).

#### Make sure components that conditionally reveal other questions still work as expected

Expand Down

0 comments on commit d0ae7e4

Please sign in to comment.