Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML validation error: 'Attribute src not allowed on element image at this point' in header #2263

Closed
dan-earle opened this issue Jun 29, 2021 · 2 comments
Closed

HTML validation error: 'Attribute src not allowed on element image at this point' in header #2263

dan-earle opened this issue Jun 29, 2021 · 2 comments
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) header

Comments

@dan-earle
Copy link

dan-earle commented Jun 29, 2021 •
edited
Loading

validator.w3.org reports:

Error: Attribute src not allowed on element image at this point.

From line 49, column 19; to line 49, column 160

      <image src="assets/images/govuk-logotype-crown.png" xlink:href="" class="govuk-header__logotype-crown-fallback-image" width="36" height="32"/>`

This was already reported but missed here; first issue on this old bug: #1298

Description of the issue

HTML5 validator reports: Error: Attribute src not allowed on element image at this point. for uk gov logo

Steps to reproduce the issue

Go to https://validator.w3.org/#validate_by_uri and enter https://design-system.service.gov.uk/ look at issue (Error) number 2

Actual vs expected behaviour

Hoping no validation errors :)

Environment (where applicable)

Windows PC

  • Operating system:
  • Browser:
  • Browser version:
  • GOV.UK Frontend Version: 3.12.0
@dan-earle dan-earle added awaiting triage Needs triaging by team 🐛 bug Something isn't working the way it should (including incorrect wording in documentation) labels Jun 29, 2021
@dan-earle
Copy link
Author

Sorry is already covered by #1280 and will be fixed in next version

@36degrees
Copy link
Contributor

Thanks @dan-earle. I can confirm that this was fixed in GOV.UK Frontend v3.13.0, which was released last week.

@36degrees 36degrees changed the title HTML5 validation error HTML5 validation error: Attribute src not allowed on element image at this point Jul 4, 2022
@36degrees 36degrees added header and removed awaiting triage Needs triaging by team labels Jul 4, 2022
@36degrees 36degrees changed the title HTML5 validation error: Attribute src not allowed on element image at this point HTML5 validation error: 'Attribute src not allowed on element image at this point' in heaer Jul 4, 2022
@36degrees 36degrees changed the title HTML5 validation error: 'Attribute src not allowed on element image at this point' in heaer HTML5 validation error: 'Attribute src not allowed on element image at this point' in header Jul 4, 2022
@36degrees 36degrees changed the title HTML5 validation error: 'Attribute src not allowed on element image at this point' in header HTML validation error: 'Attribute src not allowed on element image at this point' in header Jul 4, 2022
@36degrees 36degrees mentioned this issue Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working the way it should (including incorrect wording in documentation) header
Projects
GOV.UK Frontend - Known issues flagged by validators or automated testing tools
Status: Fixed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@36degrees @dan-earle