Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html validation errors #1298

Closed
joelanman opened this issue Apr 26, 2019 · 2 comments · Fixed by #1419
Closed

html validation errors #1298

joelanman opened this issue Apr 26, 2019 · 2 comments · Fixed by #1419
Assignees
@36degrees
Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve.
Milestone
v2.13.0

Comments

@joelanman
Copy link
Contributor

In HMTL5 validator we get the following errors:

Error: Attribute src not allowed on element image at this point.

From line 73, column 13; to line 73, column 117

          <image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag

Error: Element image is missing required attribute height.

From line 73, column 13; to line 73, column 117

          <image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag

Error: Element image is missing required attribute width.

From line 73, column 13; to line 73, column 117

          <image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag
@joelanman joelanman added the awaiting triage Needs triaging by team label Apr 26, 2019
@36degrees
Copy link
Contributor

We can fix the latter two, but the first one is intentional as we're using it as a fallback for the SVG.

@joelanman
Copy link
Contributor Author

probably related to #1280

@timpaul timpaul added 🕔 hours A well understood issue which we expect to take less than a day to resolve. Priority: low and removed awaiting triage Needs triaging by team labels May 8, 2019
@36degrees 36degrees self-assigned this Jun 3, 2019
36degrees added a commit that referenced this issue Jun 3, 2019
@36degrees
Add width and height to header crown fallback PNG
b54f1bf 
This addresses two issues flagged by the HTML5 validator.

Error: Element image is missing required attribute height.

From line 73, column 13; to line 73, column 117

          <image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag

Error: Element image is missing required attribute width.

From line 73, column 13; to line 73, column 117

          <image src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image"></imag

Fixes #1298
@36degrees 36degrees mentioned this issue Jun 3, 2019
Merged
@36degrees 36degrees added this to the v2.13.0 milestone Jun 13, 2019
@dan-earle dan-earle mentioned this issue Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@36degrees 36degrees

Labels
🕔 hours A well understood issue which we expect to take less than a day to resolve.
Projects
GOV.UK Design System cycle board
Archived in project
Milestone
v2.13.0
Development

Successfully merging a pull request may close this issue.

Fixes for header fallback 'crown' PNG alphagov/govuk-frontend
3 participants
@36degrees @joelanman @timpaul