Update to GOV.UK Frontend v5.2.0 on management pages #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinrotherham
force-pushed
the
frontend-5.2.0
branch
from
003893b to
5acf2a4
Compare
2 tasks
colinrotherham
commented
Feb 22, 2024
Comment on lines
+297
to
+298
| govukFrontend, | ||
| govukFrontendInternal, |
There was a problem hiding this comment.
For template previews we use a minimal Nunjucks context only
But to correctly build assetPath we need GOV.UK Frontend paths to close #2392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to GOV.UK Frontend v5.2.0 (including the new crown) to close #2395
Also closes #2392 where
assetPathwasn't fully set for template previews