9.10.0: Always initialise GovukPrometheusExporter. #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KludgeKML
approved these changes
Mar 26, 2024
|
This should eliminate the need for the workaround in alphagov/finder-frontend#3318 and alphagov/search-api-v2#246 (hopefully without introducing any other significant issues 😅) |
Some client apps have started to assume that the Prometheus "exporter" process (i.e. the process that aggregates counters in multi-process apps) is always available, including in tests. Now that we handle the case where the `/metrics` port is already taken, there's really no reason not to initialise GovukPrometheusExporter. Remove the confusing heuristics in `GovukPrometheusExporter.should_configure` and just always attempt to initialise unless we're running under `rails console`. When the init fails, we just print a warning and continue anyway, so this should be a net win for robustness. If we find edge cases where this still needs to be configurable then I propose we address those if/when we find and understand them. I expect we won't need to, though.
sengi
force-pushed
the
sengi/govuk-prom-defaults
branch
from
2397073 to
3c6dd35
Compare
|
Realised I'd missed out the words "environment variable" in the changelog entry 🙃 (force-pushed to update) |
sengi
added a commit
to alphagov/govuk-helm-charts
that referenced
this pull request
Mar 26, 2024
`GOVUK_PROMETHEUS_EXPORTER` was removed in alphagov/govuk_app_config#361, so once that lands in all its consumer apps we can remove it from the config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some client apps have started to assume that the Prometheus "exporter" process (i.e. the process that aggregates counters in multi-process apps) is always available, including in tests.
Now that we handle the case where the
/metricsport is already taken, there's really no reason not to initialise GovukPrometheusExporter.Remove the confusing heuristics in
GovukPrometheusExporter.should_configureand just always attempt to initialise unless we're running underrails console. When the init fails, we just print a warning and continue anyway, so this should be a net win for robustness.If we find edge cases where this still needs to be configurable then I propose we address those if/when we find and understand them. I expect we won't need to, though.
Kudos to @leenagupte for reporting the issue.