Add a glance_metric component
#4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
add-glance-metric-component
branch
from
1cace6c to
55dc5a7
Compare
AshGDS
reviewed
Nov 29, 2024
app/assets/stylesheets/govuk_publishing_components/components/_glance-metric.scss
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/_glance_metric.html.erb
Outdated
Show resolved
Hide resolved
app/views/govuk_publishing_components/components/docs/glance_metric.yml
Outdated
Show resolved
Hide resolved
app/assets/stylesheets/govuk_publishing_components/components/_glance-metric.scss
Outdated
Show resolved
Hide resolved
pezholio
force-pushed
the
add-glance-metric-component
branch
from
55dc5a7 to
68a8147
Compare
pezholio
force-pushed
the
add-glance-metric-component
branch
from
68a8147 to
bac6f4c
Compare
pezholio
force-pushed
the
add-glance-metric-component
branch
from
bac6f4c to
d25ff76
Compare
AshGDS
approved these changes
Nov 29, 2024
| - communicate number value and label (if present) in a single dictation when read with a screen reader | ||
| - convey the meaning of the number shown | ||
| - The component must use the correct heading level for the page (defaults to `<h3>`) | ||
|
|
There was a problem hiding this comment.
Could you add uses_component_wrapper_helper: true so the functionality of it is surfaced in the docs? Thanks
This is based on the `glance_metric` component used in [content-data-admin](https://github.com/alphagov/content-data-admin) with some unused options removed. I’ve also tweaked the display of the explicit label, as `aria-label` is not supported on non-semantic elements,
pezholio
force-pushed
the
add-glance-metric-component
branch
from
d25ff76 to
d4f4dd8
Compare
pezholio
added a commit
that referenced
this pull request
Dec 2, 2024
* Use component wrapper on panel component ([PR #4459](#4459)) * Use the component wrapper on the phase banner component ([PR #4460](#4460)) * Add a `glance_metric` component ([PR #4452](#4452)) * Use component wrapper on org logo component ([PR #4458](#4458)) * Use component wrapper on notice component ([PR #4444](#4444)) * Add component wrapper to the metadata component ([PR #4442](#4442))
Merged
pezholio
added a commit
that referenced
this pull request
Dec 2, 2024
* Use component wrapper on panel component ([PR #4459](#4459)) * Use the component wrapper on the phase banner component ([PR #4460](#4460)) * Add a `glance_metric` component ([PR #4452](#4452)) * Use component wrapper on org logo component ([PR #4458](#4458)) * Use component wrapper on notice component ([PR #4444](#4444)) * Add component wrapper to the metadata component ([PR #4442](#4442))
pezholio
added a commit
that referenced
this pull request
Dec 2, 2024
* Use component wrapper on panel component ([PR #4459](#4459)) * Use the component wrapper on the phase banner component ([PR #4460](#4460)) * Add a `glance_metric` component ([PR #4452](#4452)) * Use component wrapper on org logo component ([PR #4458](#4458)) * Use component wrapper on notice component ([PR #4444](#4444)) * Add component wrapper to the metadata component ([PR #4442](#4442))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the
glance_metriccomponent used in content-data-admin with some unused options removed. I’ve also tweaked the display of the explicit label, asaria-labelis not supported on non-semantic elements,Screenshot
Trello card: https://trello.com/c/eJTfFnFN/700-create-rollup-for-view-page-and-review-page