Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update options so the new chrome driver version 120 will work #68

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Update options so the new chrome driver version 120 will work #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/govuk_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def self.configure

def self.headless_chrome_selenium_options
Selenium::WebDriver::Chrome::Options.new.tap do |options|
options.add_argument("--headless")
options.add_argument("--headless=new")
options.add_argument("--no-sandbox") if ENV["GOVUK_TEST_CHROME_NO_SANDBOX"]
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/govuk_test_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
options = described_class.headless_chrome_selenium_options

expect(options).to be_instance_of(Selenium::WebDriver::Chrome::Options)
expect(options.args).to include("--headless")
expect(options.args).to include("--headless=new")
end

it "can be configured with an environment variable to run in no-sandbox" do
Expand Down