Release version 4.11.0 #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release drops support for Ruby 2.7 (*breaking*) and also updates rubocop, rubocop-ast, rubocop-rails, rubocop-rake and rubocop-rspec. Summary of changes in [this diff](https://github.com/alphagov/rubocop-govuk/compare/c55d9f8a9b0693a0a4e6f93346e52362e4d43007..58b7f20640b4b68661f3771b0e803d83fc04ff12). Tested against the following apps (following the precedent in #272): - [Whitehall](https://github.com/alphagov/rubocop-govuk/actions/runs/5398651979/jobs/9804729806) ✅ - [Content Publisher](https://github.com/alphagov/rubocop-govuk/actions/runs/5398750820) 5 offences detected: - 4 `FactoryBot/CreateList` 'convention' violations ("Prefer `create_list`" where app has used for example `image_revisions: [create(:image_revision, filename: "960x640.jpg")],`) - Autocorrectable ✅ - 1 `Lint/RedundantCopDisableDirective` 'warning' violation ("Unnecessary disabling of `Rails/CreateTableWithTimestamps`" for line `create_table :active_storage_variant_records do |t| # rubocop:disable Rails/CreateTableWithTimestamps`). - This appears to be down to [a change in rubocop-rails](rubocop/rubocop-rails#1011) in [2.20.0](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md#2200-2023-06-18) - [Search API](https://github.com/alphagov/rubocop-govuk/actions/runs/5398752770) ✅ - [GDS API Adapters](https://github.com/alphagov/rubocop-govuk/actions/runs/5398753882) ✅
ChrisBAshton
force-pushed
the
release-4.11.0
branch
from
6614f62
to
55ea083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release drops support for Ruby 2.7 (breaking) and also updates rubocop, rubocop-ast, rubocop-rails, rubocop-rake and rubocop-rspec. Summary of changes in this diff.
Tested against the following apps (following the precedent in #272):
FactoryBot/CreateList'convention' violations ("Prefercreate_list" where app has used for exampleimage_revisions: [create(:image_revision, filename: "960x640.jpg")],)Lint/RedundantCopDisableDirective'warning' violation ("Unnecessary disabling ofRails/CreateTableWithTimestamps" for linecreate_table :active_storage_variant_records do |t| # rubocop:disable Rails/CreateTableWithTimestamps).