Bump Ruby to 3.2.6 #3063
Merged
Bump Ruby to 3.2.6 #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've had to revert out Ruby bump to 3.3.6 due to an issue with the load
traffic job. We were getting the following error:
```
oogle::Cloud::CanceledError: 1:CANCELLED. debug_error_string:
{
UNKNOWN:Error received from peer {
created_time:"2024-11-20T22:00:03.584412449+00:00",
grpc_status:1,
grpc_message:"CANCELLED"
}
} (Google::Cloud::CanceledError)
/usr/local/bundle/ruby/3.3.0/gems/google-analytics-data-v1beta-0.13.1/lib/google/analytics/data/v1beta/analytics_data/client.rb:369:
```
Looking the gems repo we can see that someone else has opened an issue
for the same error googleapis/google-cloud-ruby#27448
govuk-ruby-base (https://github.com/alphagov/govuk-ruby-images/blob/93c59fe31019cc0621f607ac6bbb0683b111e1b6/README.md?plain=1#L8)
only takes minor version of Ruby so we can't bump higher than 3.2 or the production
apps will defer to the latest stable Ruby version which will break the
rake task.
This bumps Ruby to the latest 3.2 version which is 3.2.6. Once the issue
has been resolved we can then bump this to 3.3.6 (or a later version
if one is released).
kevindew
approved these changes
Nov 21, 2024
|
thanks good spot. Have fixed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've had to revert out Ruby bump to 3.3.6 due to an issue with the load traffic job. We were getting the following error:
Looking at the gems repo we can see that someone else has opened an issue for the same error here
govuk-ruby-base (https://github.com/alphagov/govuk-ruby-images/blob/93c59fe31019cc0621f607ac6bbb0683b111e1b6/README.md?plain=1#L8) only takes minor version of Ruby so we can't bump to say 3.3.4 as the production apps will use to the latest stable Ruby version (3.3.6) which will break the rake task.
This bumps Ruby to the latest 3.2 version which is 3.2.6. Once the issue has been resolved we can then bump this to 3.3.6 (or a later version if one is released).
Testing
I've deployed this out to to integration and manually kicked off the load traffic rake task to check it's working and then deleted the job.
Trello card
https://trello.com/c/xG4hrLyP/2169-investigate-fixing-the-search-api-loadpagetraffic-job