Finder loader via slug #2305
Draft
Finder loader via slug #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filename and slug are wildly different in specialist document schemas. In order to make running rake tasks and maintanence as easy as we can, it's better to use slug since we can see it directly on the website and user queries.
minhngocd
force-pushed
the
finder-loader-via-slug
branch
from
21b57a0
to
5e6d886
Compare
To make functionality consistent across publishing and unpublishing, and using slug to load the schema for ease of running support tasks, there is no longer a need to load a finder schema by filename.
minhngocd
force-pushed
the
finder-loader-via-slug
branch
from
5e6d886
to
8e2ee66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support tasks for publishing and unpublishing specialist finders were previously done via filename.
However, filename and slug are wildly different in specialist publisher. In order to minimise confusion and ease of support, slug should be used since it is external facing and will likely be used in user queries and visible on the website.
Adding functionality to load by slug, and removing functionality to load by filename
Follow these steps if you are doing a Rails upgrade.