Add new facet to SFO finder #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDSNewt
force-pushed
the
SFO-Finder-iteration-2
branch
4 times, most recently
from
3a62be1
to
ffbf934
Compare
lauraghiorghisor-tw
requested changes
Nov 8, 2024
app/models/sfo_case.rb
Outdated
| @@ -1,8 +1,10 @@ | |||
| class SfoCase < Document | |||
| validates :sfo_case_state, presence: true | |||
| validates :sfo_case_opened_date, allow_blank: true, date: true | |||
There was a problem hiding this comment.
Can you please check with the users if they want to have this as a required field or not? It was not clear to me that it's optional from the Zendesk ticket.
There was a problem hiding this comment.
Have checked and they want it to be mandatory, have amended the validation
GDSNewt
force-pushed
the
SFO-Finder-iteration-2
branch
3 times, most recently
from
cf3c4a6
to
d4a77d3
Compare
GDSNewt
force-pushed
the
SFO-Finder-iteration-2
branch
from
d4a77d3
to
37fee33
Compare
lauraghiorghisor-tw
approved these changes
Nov 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an additional facet to the new to SFO Finder specialist finder. As per documentation found here
First PR
Trello
Zendesk