Upgrade Express to fix security issue #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependabot has alerted us to a security issue with `cookie`, a dependency of `express`, in turn a dependency of `jasmine-browser-runner`. A fix has been released for `express`, but `jasmine-browser-runner` isn't frequently updated, so I'm adding a resolution for `express` in the meantime https://github.com/alphagov/transition/security/dependabot/56
It's unusual for the scripts to go after the dependencies
This helps devs who use nodenv, though based on other alphagov repos, it looks as though Dependabot doesn't keep it up to date (and possibly ignore it altogether when resolving dependencies)
Gweaton
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot has alerted us to a security issue with
cookie, a dependency ofexpress, in turn a dependency ofjasmine-browser-runner. A fix has been released forexpress, butjasmine-browser-runnerisn't frequently updated, so I'm adding a resolution forexpressin the meantimehttps://github.com/alphagov/transition/security/dependabot/56
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.