Redesign Licenses Screen #31
Conversation
kevinrpb
force-pushed
the
master
branch
2 times, most recently
from
7953c64 to
fae4610
Compare
|
@rileytestut any chance for feedback here when you have some time? =) |
|
@kevinrpb I just saw this preview and I actually really enjoyed it (not to sound surprised, all i mean by that is "how can you improve the licensing screen?" was my expectation) but I really like it, are you a part of the discord? if you'd like i could forward this over to him. |
|
@dlevi309 Thank you =) I am not part of it. Is it public? |
|
@kevinrpb yeah man :) and it is not public, you would have to join the 5$ a month pledge on his patreon, he's very responsive on it and would probably love to see this directly from you, but id be happy to put this on the channel for you 🙂 |
| } | ||
|
|
||
| navigationItem.title = product | ||
| copyrightLabel.text = copyright != "" ? copyright : "(no copyright line)" |
|
|
||
| let url = URL(fileURLWithPath: path) | ||
|
|
||
| guard let data = try? Data(contentsOf: url), let json = try? JSONSerialization.jsonObject(with: data) as? [[String: String]] else { |
There was a problem hiding this comment.
I suggest to go with Codable protocol instead of JSONSerialization
| break | ||
| default: | ||
| cell.style = .middle | ||
| } |
There was a problem hiding this comment.
Move this switch case comparison to separate function. Like
cell.style = getStyleFor(license: [String: String])
|
Would be great to get this approved, looks great! |
|
Looks amazing! +1 |
I thought the TextView looked a bit odd with the rest of the design. I'm starting to refactor it a bit. So far I've put the licenses into a JSON (this also allows to manage them dynamically if they change; or even fetch them if appropriate). Using this, the Licenses navigation gets you to a table view that will display a line for each product.
Here's a preview of the new screen