refactor: ⬆️ Update ureq #2699
Open
refactor: ⬆️ Update ureq #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-personified-devil
requested changes
Feb 13, 2025
alvr/adb/src/commands.rs
Outdated
| .headers() | ||
| .get("Content-Length") | ||
| .map(|l| l.to_str().ok()) | ||
| .flatten() |
Comment on lines
+197
to
+200
| // todo: this should be changed to a GET request, requires removing body | ||
| request_agent | ||
| .get(&uri) | ||
| .set("X-ALVR", "true") | ||
| .post(&uri) | ||
| .header("X-ALVR", "true") |
There was a problem hiding this comment.
huh? I guess post will also work, but wdym by removing body for the get? If anything I think it should be kept as a get in the scope of this pr, so you gotta explain a bit further why that's not possible
There was a problem hiding this comment.
Using the new ureq 3.0 api, when using get() you can't later call send_json. I think they split the builder struct to disable unidiomatic usages
There was a problem hiding this comment.
In general GET requests shouldn't have a body and all the info they send to the server required for the request should be put in the URL itself. this means we should remove the DashboardRequest structure and make separate URLs (as it was before)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.