Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple calls to RefreshDetectedYuzuInstallationStateAsync() #34

Closed
wants to merge 1 commit into from

Conversation

informagico
Copy link

Starting EzYuzu with empty Settings.YuzuLocation and selecting the directory via BtnBrowse will result in multiple calls to the "search for updates routine", from both:

private async void CboUpdateChannel_SelectedIndexChangedAsync(object sender, EventArgs e) { ... }
private async void BtnBrowse_ClickAsync(object sender, EventArgs e) { ... }

This change add a guard to the CboUpdateChannel_SelectedIndexChangedAsync event (similar to what has already been implemented in the CboUpdateVersion_SelectedIndexChangedAsync event).

Please consider looking for unexpected behaviours because I'm not 100% familiar with this codebase (yet 😄 ).

@amakvana
Copy link
Owner

amakvana commented Oct 8, 2023

Closed - Merged in v1.6.2.0
https://github.com/amakvana/EzYuzu/releases/latest

@amakvana amakvana closed this Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants