Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: set a minimum sagemaker version to avoid cython build issues #298

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

AbeCoull
Copy link
Contributor

@AbeCoull AbeCoull commented Oct 18, 2024

Issue #, if available:

Description of changes:
PyYaml < 6 is broken due to the cython upgrade to 3.x. Therefore, we constrain sagemaker to the version that uses PyYaml~=6 to avoid the cython build issues.

yaml/pyyaml#736

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AbeCoull AbeCoull marked this pull request as ready for review October 18, 2024 16:41
@AbeCoull AbeCoull requested a review from a team as a code owner October 18, 2024 16:41
@AbeCoull AbeCoull changed the title infra: unpin pytest and invoke in the test requirements infra: set a minimum sagemaker version to avoid cython build issues Oct 18, 2024
@AbeCoull AbeCoull merged commit d6af96f into main Oct 21, 2024
17 checks passed
@AbeCoull AbeCoull deleted the math411-patch-4 branch October 21, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants