Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clifford.py #257

Conversation

AbdullahKazi500
Copy link

@AbdullahKazi500 AbdullahKazi500 commented May 31, 2024

in this updated code
defined the AbstractProgramContext class, OpenQASMProgram class, and GateModelTaskResult class. implemented the CliffordSimulator class, which inherits from OpenQASMSimulator, and the CliffordProgramContext class, which implements the AbstractProgramContext interface. In the CliffordSimulator class, provide implementations for the create_program_context and parse_program methods. In the CliffordProgramContext class, implemented the add_gate_instruction method to handle the translation of OpenQASM instructions into Clifford simulator instructions. an example usage of the framework, create an OpenQASM program, instantiate a CliffordSimulator, parse the program, and add gate instructions to the program context.

Issue #, if available:
#253
Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

in this updated code
defined the AbstractProgramContext class, OpenQASMProgram class, and GateModelTaskResult class as provided in your initial snippet.
implemented the CliffordSimulator class, which inherits from OpenQASMSimulator, and the CliffordProgramContext class, which implements the AbstractProgramContext interface. In the CliffordSimulator class, provide implementations for the create_program_context and parse_program methods. In the CliffordProgramContext class, implemented the add_gate_instruction method to handle the translation of OpenQASM instructions into Clifford simulator instructions.
an example usage of the framework, create an OpenQASM program, instantiate a CliffordSimulator, parse the program, and add gate instructions to the program context.
@AbdullahKazi500 AbdullahKazi500 requested a review from a team as a code owner May 31, 2024 08:09
Copy link
Member

@speller26 speller26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Please make all changes to the src/default_simulator directory (so they can be installed), and add unit tests.

def __init__(self, **kwargs):
self.__dict__.update(kwargs)

class CliffordSimulator(OpenQASMSimulator):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to actually run a program; what the issue asks for is a concrete implementation of a Clifford simulator

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @speller26 any tips or resources on this from a previous build that you can share I am trying to follow this paper here
https://arxiv.org/abs/2303.10788

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first glance, it looks like the paper you shared is for circuit cutting rather than simulation. Good examples for the latter are Stim and Qiskit's Clifford.

@speller26
Copy link
Member

Closing as this isn't being worked on.

@speller26 speller26 closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants