Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use measurements getting return types #222

Merged
merged 5 commits into from
Jan 17, 2024
Merged

feat: use measurements getting return types #222

merged 5 commits into from
Jan 17, 2024

Conversation

AbeCoull
Copy link
Contributor

@AbeCoull AbeCoull commented Jan 11, 2024

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AbeCoull AbeCoull requested a review from speller26 January 11, 2024 00:48
@AbeCoull AbeCoull requested a review from a team as a code owner January 11, 2024 00:48
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (872a3a8) 100.00% compared to head (32145d7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1180      1183    +3     
  Branches       286       286           
=========================================
+ Hits          1180      1183    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull AbeCoull merged commit ec09acd into main Jan 17, 2024
15 checks passed
@AbeCoull AbeCoull deleted the return_types branch January 17, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants