Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning when falling back on param-shift #224

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Raise warning when falling back on param-shift #224

merged 1 commit into from
Jan 18, 2024

Conversation

speller26
Copy link
Member

@speller26 speller26 commented Jan 18, 2024

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@speller26 speller26 requested a review from a team as a code owner January 18, 2024 00:31
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec09acd) 100.00% compared to head (5941e5e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #224   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1183      1185    +2     
  Branches       286       286           
=========================================
+ Hits          1183      1185    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speller26 speller26 merged commit c145947 into main Jan 18, 2024
15 checks passed
@speller26 speller26 deleted the warning branch January 18, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BraketAwsQubitDevice unnecessarily computes parameter-shifted gradients for SV1.
2 participants