fix: update test to use DummyOp #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1185 1185
Branches 286 286
=========================================
Hits 1185 1185 ☔ View full report in Codecov by Sentry. |
|
Hi, @lillian542, this looks good to me. Only minor thing is can you prefix the commit title with |
lillian542
force-pushed
the
fix_test_error
branch
from
6abebfe to
6bb6880
Compare
|
@math411, sorry, forgot about that! It's updated now :) |
AbeCoull
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A test for how the AHS device handles operators with undefined diagonalizing gates is failing because it uses
CNOT, which now does have a definition for diagonalizing gates in PennyLane 0.35.We update the test to use a
DummyOpcreated in the test, that should continue to have undefined diagonalizing gates.