Add --clang-format-version option

[tylerjw]

Signed-off-by: Tyler Weaver [email protected]

Description

I am using clang-format-10. This change would enable me to use ament_clang_format with clang-format-10. Note that find_executable will return as soon as it finds a valid executable. This means that if we search in this order searching for clang-format- first causes no harm in the case where the user does not provide a value for this.

Follow-on work (for other PRs)

• ament_cmake_clang_format should be updated to enable using this option from cmake.
• Would it be a good practice to search the filesystem for a .clang_format file in the working directory or in a parent and use that instead if it exists for the config? This would simplify running ament_clang_format in a repo that contains a config. If this default behavior would be accepted, it should also be done for clang-tidy.

[mm318]

Can you also please update the doc regarding the new option that you're adding?

[tylerjw]

I updated the documentation to include instructions for setting these variables. I will create a follow-on PR for ament_cmake_clang_format to allow setting this option from the cmake function later.

[mm318]

Looks good to me, pending CI (I will start CI as soon as I can).

[mm318]

• Linux
• Linux-aarch64
• macOS
• Windows

[mikepurvis]

I updated the documentation to include instructions for setting these variables. I will create a follow-on PR for ament_cmake_clang_format to allow setting this option from the cmake function later.

AFAICT this didn't end up happening?

Edit: Ah, I see from #289 (comment) that you ended up solving the issue a different way.