Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DenseVecStorage is not really that dense - should be mentioned in the docs? #484

Closed
idanarye opened this issue Sep 26, 2018 · 2 comments
Closed
Labels

Comments

@idanarye
Copy link

Reading the DenseVecStorage docs gives the impression that everything is densely packed, trading some access performance for better memory usage. Which is true - but a bit misleading, since only the data is dense. The index vector is still sparse.

I think it's worth mentioning that in the docs - that DenseVecStorage can still have a big memory footprint for a small number of entities if their IDs are large.

@torkleyy
Copy link
Member

Fair point.

@zeroexcuses
Copy link

Thanks for pointing this out. Up until this point, I thought "DenseVecStorage" was

"entity id -> location" in BTree,
"location -> data" in Vec

Was not aware the "entity -> location" was in a sparse Vec

bors bot added a commit that referenced this issue Jan 3, 2019
527: Clarify dense property of DenseVecStorage r=torkleyy a=torkleyy

Fixes #484

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/527)
<!-- Reviewable:end -->


528: Fix grammar of RestrictedStorage docs r=torkleyy a=torkleyy

Fixes #491

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/slide-rs/specs/528)
<!-- Reviewable:end -->


Co-authored-by: Thomas Schaller <[email protected]>
@bors bors bot closed this as completed in #527 Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants