Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionized get_mut_or_default #563

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Optionized get_mut_or_default #563

merged 1 commit into from
Mar 29, 2019

Conversation

JaniM
Copy link
Contributor

@JaniM JaniM commented Mar 8, 2019 •
edited by torkleyy
Loading

Fixes #561
Alternative to #562 . Implements an Option API instead of panicking if the entity is dead

I have no idea how I managed to mess up the branch name.

Closes #562

This change is Reviewable

@JaniM JaniM force-pushed the feat/sensible-derives-opt branch from 287e3d9 to 9d5b041 Compare March 8, 2019 09:54
torkleyy
torkleyy approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@torkleyy torkleyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
bors r+

bors bot added a commit that referenced this pull request Mar 29, 2019
@bors @JaniM
Merge #563
284bf99 
563: Optionized get_mut_or_default r=torkleyy a=JaniM

Fixes #561
Alternative to #562 . Implements an Option API instead of panicking if the entity is dead

I have no idea how I managed to mess up the branch name.



Co-authored-by: Jani Mustonen <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 29, 2019

Build succeeded

@bors bors bot merged commit 9d5b041 into amethyst:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkleyy torkleyy torkleyy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaniM @torkleyy