Code

Safety#765

Code

Merged

Imberflur merged 47 commits intoamethyst:masteramethyst/specs:masterfrom Imberflur:safetyImberflur/specs:safetyCopy head branch name to clipboardSep 24, 2023

+2,841-1,048

Commits

Commits on Jul 23, 2023

• Switch UnprotectedStorage::get_mut to accept &self

  Show description for 2f331ad
  Imberflur

  committed
  2f331ad

• Update safety comments on uses of UnprotectedStorage::get_mut and change how

  Show description for 8366ddb
  Imberflur

  committed
  8366ddb

• Change GAT where clause location to match new formatting recommendation

  Imberflur

  committed
  ba8b976

• Update DerefFlaggedStorage to account for changes, get_mut impl postponed since

  Show description for ac2146d
  Imberflur

  committed
  ac2146d

• Refactor UnprotectedStorage and add SharedGetAccessMut trait

  Show description for bf620e1
  Imberflur

  committed
  bf620e1

• Refactor Join family of traits so they can be more safely implemented/used:

  Show description for e7d0aa1
  Imberflur

  committed
  e7d0aa1

• Update Join/ParJoin/Unprotected implementations to match changes in these traits

  Show description for cc97588
  Imberflur

  committed
  cc97588

• Implement SharedGetAccessMutStorage for applicable storages and update storage

  Show description for 483914b
  Imberflur

  committed
  483914b

• Remove get_mut, rename get_access_mut -> get_mut, rename

  Show description for 57e929c
  Imberflur

  committed
  57e929c

• Various next steps:

  Show description for 0968089
  Imberflur

  committed
  0968089

• Modify LendJoin to support ChangeSet<T> impl of LendJoin with non 'static T

  Imberflur

  committed
  25b27e5

• Implement LendJoin for owned and referenced ChangeSet<T>

  Imberflur

  committed
  448c9de

• Changes to allow soundly implementing Join/LendJoin for the owned ChangeSet<T>

  Show description for 919434b
  Imberflur

  committed
  919434b

• Updated safety comments for impls/uses of Join (see previous commit for

  Show description for d2d05f2
  Imberflur

  committed
  d2d05f2

• Address a few compile errors that snuck through when enabling additional

  Show description for ce90ce7
  Imberflur

  committed
  ce90ce7

• Add lend_join example and make Miri run it without errors by fixing an issue in shred

  Imberflur

  committed
  bea1ea9

• Remove "nightly" feature now that generic associated types have stabilized and

  Show description for e22d22a
  Imberflur

  committed
  e22d22a

• Uncomment entry module and rework implementation:

  Show description for 738dc16
  Imberflur

  committed
  738dc16

• Implement refactored Join traits for RestrictedStorage and other related

  Show description for e4c3655
  Imberflur

  committed
  e4c3655

• Update implementations of ParJoin and callers of ParJoin::get to reflect changes

  Show description for 6ca2338
  Imberflur

  committed
  6ca2338

• Uncomment drain module, update safety comments and implement LendJoin for

  Show description for 0fad41d
  Imberflur

  committed
  0fad41d

• Fix errors and warnings in tests and examples

  Imberflur

  committed
  2c7d5e6

• Add missing documentation and fix some doc tests

  Imberflur

  committed
  c33cd7c

• Adjust for changes in shred MetaTable

  Imberflur

  committed
  09f1a4c

• Reduce loop iterations on some tests when running with Miri so that they finish in a reasonable time

  Imberflur

  committed
  c3a301f

• Appease clippy

  Imberflur

  committed
  e8f80e7

• Small update to tutorial to reflect method name change

  Imberflur

  committed
  391b310

• Enhance LendJoin docs to hopefully explain its purpose and usage

  Show description for 6b74393
  Imberflur

  committed
  6b74393

• Add test for when Send is implemented for PairedStorageWriteShared

  Imberflur

  committed
  5aa5abf

• Switch to git deps from local path deps for shred and hibitset

  Imberflur

  committed
  2beb089

• Order example entries by name

  Imberflur

  committed
  cbfa283

• Tweak rustfmt config

  Imberflur

  committed
  819d6ca

• fmt

  Imberflur

  committed
  2400172

• Fix and simply insert code unwinding handling since allocation is not actually guaranteed to abort on failure

  Imberflur

  committed
  6736f15

• Add nightly feature to enable shred/nightly for more efficient MetaTable implmenetation.

  Imberflur

  committed
  a31e781

Commits on Jul 24, 2023

• Fix typo in docs

  Imberflur

  committed
  1fc3d1f

Commits on Jul 25, 2023

• Fix various compilation warnings, change abort on unwinding during insertion into removing the inserted component (mainly to make should_panic test work)

  Imberflur

  committed
  5abd46a

Commits on Jul 26, 2023

• Remove apparently unnecessary "where Self: 'next" on LendJoin::get

  Imberflur

  committed
  de30c85

• Update MSRV to 1.70 since that is apparently necessary to remove "where Self: 'next" from LendJoin::get

  Imberflur

  committed
  35da879

• Collapse unnecessary lifetimes in restrict storages

  Imberflur

  committed
  a8c96f8

Commits on Sep 15, 2023

• Address todo in deref_flagged impl

  Imberflur

  committed
  784c7b0

Commits on Sep 16, 2023

• Switch to published versions of hibitset and shred

  Imberflur

  committed
  5d3bfe7

• Remove rustfmt bug todo since things seem to be working now

  Imberflur

  committed
  a53d28e

• Remove temporary continue-on-error setting

  Imberflur

  committed
  0a4b99a

• Run no_parallel tests under miri

  Imberflur

  committed
  6d4724b

• Update changelog

  Imberflur

  committed
  eecf83a

• Remove unnecessary borrow calls on bitset reference in restricted storage

  Imberflur

  committed
  276450e