-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decouple shuttle #38
base: master
Are you sure you want to change the base?
decouple shuttle #38
Conversation
this commit should make the server unsuable since the logic for the queries/mutations is for the old schema. DO NOT RUN THIS COMMIT.
This commit unfortunately removes the leaderboard updation via leetcode and codeforces stats to simplify my work for now. Will have to add it back later.
774383c
to
7a9a6ee
Compare
This commit changes a lot more things than just the graphql interface. Also likely introduces a few extra regressions. ¯\_(ツ)_/¯
03324a4
to
3518e18
Compare
44de20c
to
8326b0a
Compare
8326b0a
to
e2207f7
Compare
src/attendance/daily_task.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we adding this back in @ivinjabraham
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same thing here, imo it should be rewritten before a possible merge. @swayam-agrahari whats your thoughts?
|
||
let now = Local::now().with_timezone(&Kolkata).date_naive(); | ||
let attendance = sqlx::query_as::<_, Attendance>( | ||
"INSERT INTO Attendance (member_id, date, is_present, time_in, time_out, created_at, updated_at) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be updation instead of insertion. current time should be utilised for both first seen and last seen.
Fixes #24. And I'll be rewriting some of the current system in hopes to clean up some of the unintuitive stuff that crept in. I could make these into two separate PRs, but I'd rather not let the latter be delayed after decoupling.
Please take code reviews more seriously so that we don't have to keep rewriting stuff.
Changelog
Sqlx::migrate!
embeds the migrations into the binary, so unnecessary migrations will bloat the binary.These are some pretty chonky and important commits, worth reviewing twice:
TODO
Future Work
I'll be removing some of the stuff that isn't actively used now to simplify (lol) this pull request. This will be a list of stuff to do later as well as the list of stuff that I removed.
ActiveProjects
.