Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case in which a parametric link is not a box, cylinder or sphere #68

Closed
S-Dafarra opened this issue Feb 26, 2024 · 1 comment · Fixed by #72
Closed

Handle the case in which a parametric link is not a box, cylinder or sphere #68

S-Dafarra opened this issue Feb 26, 2024 · 1 comment · Fixed by #72

Comments

@S-Dafarra
Copy link
Member

S-Dafarra commented Feb 26, 2024

When specifying a link as a parametric, only the box, sphere, and cylinder cases seem to be supported. In fact, looking at the code of compute_volume, if we are not in one of the three cases mentioned, the output volume is 0, while visual_data_new is not defined.

Similarly, the inertia computation is done only in these three cases.

It would be useful to trigger a meaningful error when the input link is not a box, cylinder or sphere, but defined by a mesh for example.

cc @CarlottaSartore

@S-Dafarra
Copy link
Member Author

Throwing an exception in 8e25f02 (included in #72)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant