Remove outdated tests - PR2 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isorrentino
requested review from
GiulioRomualdi and
S-Dafarra
as code owners
S-Dafarra
approved these changes
Oct 25, 2023
|
Hi @isorrentino it's not clear to me why they our outdated. If I'm not mistaken they are compiled and ran in the CI |
I do not know how they can run since one of the classes used by most of those tests does not exist anymore. For instance, SubModelKinDynWrapper class which is no longer defined in the master branch (the latest PR removed it). Furthermore, many tests import the SubModelKinDynWrapper class and cannot run. It's not clear to me why the CI was not failing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.