Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vector size check for joint values in setReferences in YarpRobotControl.cpp #852

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Add vector size check for joint values in setReferences in YarpRobotControl.cpp #852

merged 3 commits into from
Jun 18, 2024

Conversation

giotherobot
Copy link
Member

Fixes #851.

Now gives a clear error message if the vector size is incorrect:

[ERROR] [2024-06-13 15:35:43.808] [thread: 236092] [blf] [YarpRobotControl::Impl::setReferences] The size of the joint values is different from the number of actuated DoFs. Expected size: 7. Received size: 3.

@GiulioRomualdi
Copy link
Member

Could you please update the changelog?

@GiulioRomualdi GiulioRomualdi merged commit 46b94ea into ami-iit:master Jun 18, 2024
9 of 10 checks passed
@giotherobot giotherobot deleted the add_size_check_set_references branch June 19, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiulioRomualdi GiulioRomualdi GiulioRomualdi approved these changes

@S-Dafarra S-Dafarra Awaiting requested review from S-Dafarra S-Dafarra is a code owner

Assignees
No one assigned
Labels
🔨 component: RobotInterface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing a shorter vector to set_references results in Aborted in Python
2 participants
@giotherobot @GiulioRomualdi