Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi-Instrument Subscription and Custom Dialer Support #42

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

dyamin
Copy link
Contributor

@dyamin dyamin commented May 28, 2024

  • Added functionality to subscribe to order books of multiple instruments in a single request.
    Introduced an option to set a custom WebSocket dialer, which allows users to avoid overloading the default dialer. This is especially useful for those managing multiple exchanges.
  • Fix data race: I identified a data race issue in the client. The race condition was specifically observed in the receiver and sender methods, concurrently accessing, and modifying the c.lastTransmit map without proper synchronization.
  • resolves the issue of goroutine leaks in the client and public process methods.
  • Handle channel operations without launching unnecessary goroutines

@amir-the-h amir-the-h merged commit 1f0fb11 into amir-the-h:main Jun 5, 2024
1 check failed
@amir-the-h
Copy link
Owner

@dyamin Your PR is much appreciated and has now been merged. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants