Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macOS jobs to Travis CI and switch linux to xenial #40

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Add macOS jobs to Travis CI and switch linux to xenial #40

merged 2 commits into from
Jan 23, 2019

Conversation

webknjaz
Copy link
Contributor

No description provided.

@webknjaz
Copy link
Contributor Author

it should work once the issue with curl is fixed

@webknjaz
Copy link
Contributor Author

Ah, I just forgot to copy-paste env var

@webknjaz webknjaz force-pushed the testing/travis-macos-official-download branch from b5c2d6e to 4b04e05 Compare January 15, 2019 23:51
@coveralls
Copy link

coveralls commented Jan 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 93.865% when pulling b255e73 on webknjaz:testing/travis-macos-official-download into 9e08bee on amol-:master.

@webknjaz webknjaz force-pushed the testing/travis-macos-official-download branch 5 times, most recently from 842508f to cec4e4b Compare January 18, 2019 07:13
@webknjaz webknjaz force-pushed the testing/travis-macos-official-download branch from cec4e4b to b255e73 Compare January 18, 2019 12:33
@webknjaz
Copy link
Contributor Author

@amol- it started failing in my fork for unknown reason. I thought it was caching issue but maybe it's not. I suggest not merging it blindly for now. I may have time to check it out in a week

@amol-
Copy link
Owner

amol- commented Jan 20, 2019

It's the Python install. It's missing the /Applications/Python XX/Install Certificates.command step. See https://www.python.org/downloads/release/python-368/#macos-users

@amol-
Copy link
Owner

amol- commented Jan 22, 2019

I applied the required changes in https://github.com/amol-/dukpy/pull/41 and the builds properly passed: https://travis-ci.org/amol-/dukpy/builds/483105972

@amol- amol- merged commit b255e73 into amol-:master Jan 23, 2019
@webknjaz
Copy link
Contributor Author

webknjaz commented Feb 7, 2019

Oh great! Thanks for sharing that step :)

@webknjaz
Copy link
Contributor Author

webknjaz commented Feb 7, 2019

Now, the only thing left is adding jobs which would generate macOS-specific dists... I have some this well-implemented in https://github.com/aio-libs/multidict/blob/cec36b0/setup.py#L127-L213 + https://github.com/aio-libs/multidict/blob/cec36b0/tox.ini#L123-L131
The trick is that you should target the API of macOS 10.6 but use platform tags for all of the next ones...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@webknjaz @coveralls @amol-