Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use autocomplete for font selection. #3155
Use autocomplete for font selection. #3155
Changes from 9 commits
673d31c
aab610e
6fbec70
f958f54
304892d
f633c62
7e086b3
ee3545a
b085055
5c92430
2b91bb5
a27364f
344bfa5
4e8fac2
64b3b8d
fd253c9
b836c9e
910bd32
ed2ac0e
e2ad188
49b69d4
88f0da9
9537748
e863b68
3bc3adf
3b63efb
87f0b8d
e807df5
ca33976
591154d
f6d2865
8c577ff
d3434de
7fdd53c
45058c0
f10a177
a5cb2c7
81e6333
ced8932
a9ddd23
53f7c47
6c48a9f
7040815
17dceec
2d6a6d7
10530cb
3933a91
74534d0
302056c
6f9e7b6
f87c00a
37a3355
2bb80cf
f0f28b8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This loads the whole font stylesheet, whereas for performance reasons it might be beneficial to only load the glyphs actually needed to display the font name.
See #3027 (comment) for an example.
Then, when the font has been selected, the whole font stylesheet could be loaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some profiling here, the font is only 24kb, which is the size of a small image. As this is only loaded once the font is being displayed, it also has the benefit the preload the font before when displayed in the content of the amp page. Even 10 fonts loaded is only 240kb, which is the size of a small image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that sounds promising. I'll check it out myself while reviewing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed? It fixes the scrolling issue I spent all of today working on. Please stop making changes like this.
This file was deleted.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.