Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layers: Expose element dirty method #14686

Closed
jridgewell opened this issue Apr 17, 2018 · 0 comments
Closed

Layers: Expose element dirty method #14686

jridgewell opened this issue Apr 17, 2018 · 0 comments
Assignees
@jridgewell
Labels
P1: High Priority WG: runtime

Comments

@jridgewell
Copy link
Contributor

Certain events require DOM manipulations in the same process tick to work (eg, #14676).

So, we can't wait for a vsync mutate phase. But, if we mutate immediately, the cache will still provide invalid values until it's busted in the next mutate.

So, I need to add a method to dirty the cache immediately for these special cases.
@jridgewell jridgewell self-assigned this Apr 17, 2018
@jridgewell jridgewell changed the title Expose element dirty method Layers: Expose element dirty method Apr 17, 2018
@jridgewell jridgewell mentioned this issue Apr 17, 2018
Merged
jridgewell added a commit to jridgewell/amphtml that referenced this issue Apr 26, 2018
@jridgewell
Add dirtyElement method to Resources
5e6600e 
Fixes ampproject#14686.
@jridgewell jridgewell mentioned this issue Apr 26, 2018
Merged
jridgewell added a commit that referenced this issue May 8, 2018
@jridgewell
✨ Add dirtyElement method to Resources (#14917)
a044bbb 
* Add dirtyElement method to Resources

Fixes #14686.

* Lint

* Nits
noranazmy pushed a commit to noranazmy/amphtml that referenced this issue May 10, 2018
@jridgewell
✨ Add dirtyElement method to Resources (ampproject#14917)
83af154 
* Add dirtyElement method to Resources

Fixes ampproject#14686.

* Lint

* Nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jridgewell jridgewell

Labels
P1: High Priority WG: runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jridgewell